Bug#745600: src:mapserver: FTBFS with PHP 5.6

[Ondřej Surý]

Package: src:mapserver
Version: 6.4.1-3
Severity: important

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

we are preparing for a transition from PHP 5.5 to 5.6 and your package
has failed to build with PHP 5.6 (available from experimental):

cd /tmp/buildd/mapserver/mapserver-6.4.1/obj-x86_64-linux-gnu/mapscript/php && /usr/bin/cc  -DCOMPILE_DL=1 -Dphp_mapscript_EXPORTS -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -D_FORTIFY_SOURCE=2  -Wall -Wdeclaration-after-statement -fPIC -I/tmp/buildd/mapserver/mapserver-6.4.1/obj-x86_64-linux-gnu -I/tmp/buildd/mapserver/mapserver-6.4.1/renderers/agg/include -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/postgresql -I/usr/include/gdal -I/usr/include/librsvg-2.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/libxml2 -I/usr/include/php5 -I/usr/include/php5/main -I/usr/include/php5/TSRM -I/usr/include/php5/Zend -I/usr/include/php5/ext -I/usr/include/php5/ext/date/lib    -o CMakeFiles/php_mapscript.dir/owsrequest.c.o   -c /tmp
 /buildd/
 mapserver/mapserver-6.4.1/mapscript/php/owsrequest.c
/tmp/buildd/mapserver/mapserver-6.4.1/mapscript/php/owsrequest.c: In function 'zim_OWSRequestObj___set':
/tmp/buildd/mapserver/mapserver-6.4.1/mapscript/php/owsrequest.c:131:26: warning: variable 'php_owsrequest' set but not used [-Wunused-but-set-variable]
   php_owsrequest_object *php_owsrequest;
                          ^
/tmp/buildd/mapserver/mapserver-6.4.1/mapscript/php/owsrequest.c: In function 'zim_OWSRequestObj_loadParams':
/tmp/buildd/mapserver/mapserver-6.4.1/mapscript/php/owsrequest.c:197:48: error: 'sapi_request_info' has no member named 'raw_post_data'
                                SG(request_info).raw_post_data,
                                                ^
/tmp/buildd/mapserver/mapserver-6.4.1/mapscript/php/owsrequest.c:198:48: error: 'sapi_request_info' has no member named 'raw_post_data_length'
                                SG(request_info).raw_post_data_length, thread_context);
                                                ^
/tmp/buildd/mapserver/mapserver-6.4.1/mapscript/php/owsrequest.c: In function 'owsrequest_getenv':
/tmp/buildd/mapserver/mapserver-6.4.1/mapscript/php/owsrequest.c:363:7: warning: variable 'numElements' set but not used [-Wunused-but-set-variable]
   int numElements, i = 0;
       ^

The mapserver package use deprecated way how to access RAW POST data,
from UPGRADING.INTERNALS:

>  c. POST data handling
>  
>  The sapi_request_info's members post_data, post_data_len and raw_post_data as 
>  well as raw_post_data_len have been replaced with a temp PHP stream 
>  request_body.
>  
>  The recommended way to access raw POST data is to open and use a php://input 
>  stream wrapper.  It is safe to be used concurrently and more than once. 

This bug will become serious when PHP 5.6 hits unstable.

Ondrej

- -- System Information:
Debian Release: 7.4
  APT prefers stable
  APT policy: (900, 'stable'), (800, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJTV22EAAoJEAyZtw70/LsHbK8P/1gKParlMf7ocXC9K+HLjx/z
wFn1YcfWPMc/YmIyiz1ckGhzWkgrmHy8y2MWmNMsAXuZhTf6p4128DD91l0kbR/J
MWBkuKzoi8+ZJod5wRdXIHac9FWmepbMoL2fzFpuqf0e2GHF5aCrqxUJjQb/LAiy
pvA2XSqEy4L8CnuxlNUYiVldLwfeQQJqTisuBOo6/rVdmj84o/GbAMk7iToGYaZN
1WKFjpLtTxhmW0rYkJ8EvwUnrBoQ1XnaQ7O70UFITam0S48koUdqholWdGgD7idC
3khXWlqIqSEZKNXkJ9nSfSY+Y8GHI2l03zoBxTbA1QJfSjKxQYCAP9eInNLSTMTH
90qxtMzDfFKRjsQ+/RZI9Igu9nJOV2EfiFg3xosDYN84PPr8wEQqJwAmDsjjRdK4
PyH7+3mUvgQgu8L8Vi/4UfTOp72lzi+YLJuPextvjMvO11bRao7/uANo1tprQN8d
TXbch/rR5+DIBKVtBSGwV1VVIhziwdtFO+fYg5ConiEkN/DONBI65spDiIchBd6s
SBqtcA4NM12IJE1RDPfwL4ZWgraG3kGNnI1Egxui1t0L8meWd2Gm8PRdjA6q8Tb0
5ZYtkXUO3WWIIepwKQFVdkhC5aRKDBD5xsYJlwgcCaIZxXlFCh1QTry6tejrRHmt
dqi+vHRFRiGtLbgch59V
=zWca
-----END PGP SIGNATURE-----