Bug#934875: libhdf5-openmpi-dev: pkg-config cflags give wrong mpi include paths

[Gilles Filippini]

Hi,

On Fri, 16 Aug 2019 12:34:56 +0800 Drew Parsons <dparsons at debian.org> wrote:
> Package: libhdf5-openmpi-dev
> Version: 1.10.4+repack-10
> Severity: normal
> 
> hdf5-openmpi.pc provides CFLAGS for hdf5 as 
>   -I/usr/include/openmpi -I/usr/include/hdf5/openmpi
> 
> But /usr/include/openmpi is the wrong path. MPI header files are
> multiarch, so in 
>   -I/usr/lib/x86_64-linux-gnu/openmpi/include  -I/usr/lib/x86_64-linux-gnu/openmpi/include/openmpi
> (for amd64).
> 
> The same applies to hdf5-mpich.

As I understand it hdf5-mpich.pc is correct:
$ pkg-config --cflags --libs hdf5-mpich
-I/usr/include/hdf5/mpich -I/usr/include/x86_64-linux-gnu/mpich -L/usr/lib/x86_64-linux-gnu/hdf5/mpich -lhdf5 -Wl,-z,relro -lmpich -lm -lbacktrace -lpthread -lrt

And hdf5-openmpi.pc only needs 'Requires: ompi' with no other reference to openmpi CFLAGS and LIBS:
Name: HDF5
Description: Hierarchical Data Format 5 (HDF5) - OpenMPI version
Version: @VERSION@
Requires: ompi
Cflags: -I/usr/include/hdf5/openmpi
Libs: -L/usr/lib/@MULTIARCH@/hdf5/openmpi -lhdf5

Which would give:
$ pkg-config --cflags --libs hdf5-openmpi
-pthread -I/usr/include/hdf5/openmpi -I/usr/lib/x86_64-linux-gnu/openmpi/include -I/usr/lib/x86_64-linux-gnu/openmpi/include/openmpi -L/usr/lib/x86_64-linux-gnu/hdf5/openmpi -L/usr/lib/x86_64-linux-gnu/openmpi/lib -lhdf5 -lmpi

Do we agree?

Thanks,

_g.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-grass-devel/attachments/20190820/072cc8f6/attachment.sig>