[Git][debian-gis-team/pyresample][master] Fix fill value computation

[Antonio Valentino]

Dear Sebastiaan,

Il 13/03/21 11:33, Sebastiaan Couwenberg ha scritto:
> On 3/13/21 10:42 AM, Antonio Valentino wrote:
>> shall we upload this change to unstable?
> 
> No, it's just a SyntaxWarning with python3.9 so the issue is not very
> important (the bug severity should have been normal in my opinion).
> 
> If this becomes a SyntaxError with some newer Python release, then the
> bugreport is release critical.

Yes I agree with you about the severity of a SyntaxWarning, but looking 
at the coded it comes out that

if "fill" is None:

should be instead

if fill is None:

"fill" is one of the function parameters that is None by default.

So this is not just a matter of using the correct syntax to compare 
against None but a bug.
Currently that expression always evaluates to False independently on the 
value of the "fill" parameter and it should not.

The issue has never been detected or reported upstream so probably that 
piece of code is not used too often so it could be not so critical but 
it is surely a bug.

For the record, in the recent upstream release that function has been 
completely re-written.

What do you think?


ciao

-- 
Antonio Valentino