[Git][debian-gis-team/pyresample][master] Fix fill value computation

[Sebastiaan Couwenberg]

On 3/13/21 12:20 PM, Antonio Valentino wrote:
> Il 13/03/21 11:33, Sebastiaan Couwenberg ha scritto:
>> On 3/13/21 10:42 AM, Antonio Valentino wrote:
>>> shall we upload this change to unstable?
>>
>> No, it's just a SyntaxWarning with python3.9 so the issue is not very
>> important (the bug severity should have been normal in my opinion).
>>
>> If this becomes a SyntaxError with some newer Python release, then the
>> bugreport is release critical.
> 
> Yes I agree with you about the severity of a SyntaxWarning, but looking
> at the coded it comes out that
> 
> if "fill" is None:
> 
> should be instead
> 
> if fill is None:
> 
> "fill" is one of the function parameters that is None by default.
> 
> So this is not just a matter of using the correct syntax to compare
> against None but a bug.
> Currently that expression always evaluates to False independently on the
> value of the "fill" parameter and it should not.
> 
> The issue has never been detected or reported upstream so probably that
> piece of code is not used too often so it could be not so critical but
> it is surely a bug.
> 
> For the record, in the recent upstream release that function has been
> completely re-written.
> 
> What do you think?

It's indeed not the typical `if foo == None` SyntaxWarning.

If the release team agrees with the severity, the fix is eligible for
migration to testing.

You can file an unblock bugreport against release.debian.org with the
debdiff to get their input. If they agree you can upload it the unstable.

https://release.debian.org/bullseye/freeze_policy.html#appropriate

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1