tilemaker review

Felix Delattre debian at xama.nu
Fri Oct 8 12:49:27 BST 2021


On 10/8/21 7:39 AM, Sebastiaan Couwenberg wrote:
> With the cmake build system you shouldn't need as much customization in
> d/rules, like the dh_auto_install override, the various buildflag bits,
> and all the Makefile changes in the various patches.

Oh, indeed. And this also solved the problems around `file-references-package-build-path`, even without -DNDEBUG \o/

> You do need to patch CMakeList.txt to use the TM_VERSION environment
> variable instead of using git:
> 
>  execute_process(
>          COMMAND git describe --tags --abbrev=0
>          OUTPUT_VARIABLE tm_version)
>  add_compile_definitions(TM_VERSION=${tm_version})

Done.

Are we ready for experimental takeoff with tilemaker? :)

Many thanks,
Felix



More information about the Pkg-grass-devel mailing list