tilemaker review

[Sebastiaan Couwenberg]

On 10/8/21 1:49 PM, Felix Delattre wrote:
> On 10/8/21 7:39 AM, Sebastiaan Couwenberg wrote:
>> With the cmake build system you shouldn't need as much customization in
>> d/rules, like the dh_auto_install override, the various buildflag bits,
>> and all the Makefile changes in the various patches.
> 
> Oh, indeed. And this also solved the problems around `file-references-package-build-path`, even without -DNDEBUG \o/

The CONFIG variable is also obsolete as it's only used by the Makefile.
It the wrong way to set the -g compiler flag, as that's already done by
dpkg-buildflags in the CXXFLAGS environment variable.

>> You do need to patch CMakeList.txt to use the TM_VERSION environment
>> variable instead of using git:
>>
>>  execute_process(
>>          COMMAND git describe --tags --abbrev=0
>>          OUTPUT_VARIABLE tm_version)
>>  add_compile_definitions(TM_VERSION=${tm_version})
> 
> Done.
> 
> Are we ready for experimental takeoff with tilemaker? :)

Pretty much. The dh-cmake build dependency is not required because
debhelper supports the cmake buildsystem out of the box, dh-cmake
provides support more advanced CMake projects.

The changelog also didn't reflect the state of the package now that it's
using CMake, this has been trimmed down to just the Initial release
entry as is common for new packages.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1