tirex review

[Felix Delattre]

Hi Bas,

All issues you mentioned should be addressed by now.

Regarding this:

On 9/4/21 8:32 AM, Sebastiaan Couwenberg wrote:
> Why keep the mapnik version hardcoded? This requires source changes when
> the major or minor version of mapnik is incremented (e.g. 3.2 or 4.0).
> Using the version detected a build time makes rebuilding the package
> with a binNMU sufficient.

I suggest to use links for this, so the config file can stay the same and packaging is taking the bourden to ensure it links to the right version.

Is this a viable option?

Thanks,
Felix