tirex review

[Sebastiaan Couwenberg]

On 9/8/21 11:43 PM, Felix Delattre wrote:
> On 9/4/21 8:32 AM, Sebastiaan Couwenberg wrote:
>> Why keep the mapnik version hardcoded? This requires source changes when
>> the major or minor version of mapnik is incremented (e.g. 3.2 or 4.0).
>> Using the version detected a build time makes rebuilding the package
>> with a binNMU sufficient.
> 
> I suggest to use links for this, so the config file can stay the same and packaging is taking the bourden to ensure it links to the right version.
> 
> Is this a viable option?

Yes. The mapnik-plugin-base variable is not defined though.

If you create the directory and symlink via tirex.dirs & tirex.links you
don't need to remove the directory in the maintainer script and leave it
to dpkg to remove them.

You can also simplify the lintian overrides by removing the 'tirex: '
package prefix, and use a '*' pattern to match both
systemd-service-file-outside-lib paths.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1