Bug#268828: grubconf: Destroys/Overwrites menu.lst without notice

[Ralf Heiringhoff]

Package: grubconf
Version: 0.5.1-4
Severity: grave
Justification: causes non-serious data loss

Hi,

I just wanted to give grubconf a try... So I started grubconf, which
gave me a couple of errors "Was not able to find root device for <foo>.
This must be fixed!", which are actually fine because I own a buggy
Mainboard which swaps hda and hdb on bootup (don't ask). Anyways I wanted
to have a look at the GUI so I pressed a couple of the buttons the
GUI offered, but then decided that I like vim better ;)

So I hit the "Close" Button which left me without any notice what-so-ever
that it quitely is going to destroy/rewrite my menu.lst.

This behaviour can also be triggered by opening grubconf, check the
"Splash Image" CheckBox and uncheck it again and hit the Close Button.

So the Button should be at least renamed to Save+Close or something
like that.

Also the menu.lst it wrote out was completely wrong about the
"root (hdX,X)" and "root=/dev/hdXX" Values it must have read out of
the old config, thus leaving you with an unbootable system at the
next reboot.

I'm not sure if that has anything to do with #260276 grubconf: parses
"root=" in menu.lst incorrectly.

BTW:
This also destroys the comments needed for the update-grub command,
which should be at least noted in the README.Debian.

Cheers,
Ralf

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.8-1-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=de_DE.UTF-8@euro

Versions of packages grubconf depends on:
ii  grub                  0.95+cvs20040624-8 GRand Unified Bootloader
ii  libart-2.0-2          2.3.16-6           Library of functions for 2D graphi
ii  libatk1.0-0           1.6.1-3            The ATK accessibility toolkit
ii  libaudiofile0         0.2.6-4            Open-source version of SGI's audio
ii  libbonobo2-0          2.6.2-6            Bonobo CORBA interfaces library
ii  libbonoboui2-0        2.6.1-1            The Bonobo UI library
ii  libc6                 2.3.2.ds1-16       GNU C Library: Shared libraries an
ii  libesd-alsa0 [libesd0 0.2.34-1           Enlightened Sound Daemon (ALSA) - 
ii  libgconf2-4           2.6.3-2            GNOME configuration database syste
ii  libgcrypt11           1.2.0-6            LGPL Crypto library - runtime libr
ii  libglib2.0-0          2.4.6-1            The GLib library of C routines
ii  libgnome-keyring0     0.2.1-3            GNOME keyring services library
ii  libgnome2-0           2.6.1.2-2          The GNOME 2 library - runtime file
ii  libgnomecanvas2-0     2.6.1.1-2          A powerful object-oriented display
ii  libgnomeui-0          2.6.1.1-4          The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0        2.6.2-1            The GNOME virtual file-system libr
ii  libgnutls11           1.0.16-7           GNU TLS library - runtime library
ii  libgpg-error0         1.0-1              library for common error values an
ii  libgtk2.0-0           2.4.4-2            The GTK+ graphical user interface 
ii  libice6               4.3.0.dfsg.1-6     Inter-Client Exchange library
ii  libjpeg62             6b-9               The Independent JPEG Group's JPEG 
ii  liborbit2             1:2.10.2-1.1       libraries for ORBit2 - a CORBA ORB
ii  libpango1.0-0         1.4.1-2            Layout and rendering of internatio
ii  libpopt0              1.7-4              lib for parsing cmdline parameters
ii  libsm6                4.3.0.dfsg.1-6     X Window System Session Management
ii  libtasn1-2            0.2.10-4           Manage ASN.1 structures (runtime)
ii  libx11-6              4.3.0.dfsg.1-6     X Window System protocol client li
ii  libxml2               2.6.11-3           GNOME XML library
ii  xlibs                 4.3.0.dfsg.1-6     X Window System client libraries m
ii  zlib1g                1:1.2.1.1-5        compression library - runtime

-- no debconf information