Bug#403763: Error 23 on savedefault when using grub-reboot command

[dorileo]

Hi Len Sorensen

Like you said things works a bit different in grub. grub-reboot is working 
just fine in my systems I will try your patch and see if things keep working 
here.


On Tuesday 19 December 2006 12:06, Len Sorensen wrote:
> Package: grub
> Version: 0.97-20
> Severity: normal
> Tags: patch
>
> I am running with the current grub package compiled on a sarge system.
>
> When I try to use the grub-reboot command to change the boot entry to
> use on next boot as a one time choice, the /boot/grub/default is updated
> to show 0:2 as expected.  menu.lst has 'default saved'.  When booting,
> it correctly goes to entry 2, but when it hits savedefault (which should
> restore the default file back to just '0', it gets an error 23 trying to
> parse the value.  I eventually with a lot of debuging determined that
> the 'char *def' in the savedefault_helper is somehow now making it
> through when passed to safe_parse_maxint(&def, &entryno);  The following
> patch fixes it for me however:
>
> # This fixes some warnings about missing return on a function
> @@ -3660,9 +3663,9 @@
>  {
>  #if !defined(SUPPORT_DISKLESS)
>    #if !defined(GRUB_UTIL)
> -       savedefault_helper(arg, flags);
> +       return savedefault_helper(arg, flags);
>    #else
> -       savedefault_shell(arg, flags);
> +       return savedefault_shell(arg, flags);
>    #endif
>  #else /* !SUPPORT_DISKLESS */
>    errnum = ERR_UNRECOGNIZED;

correct, however it`s not making any problem in stage2 it`ll not return 
anything.

--
Dorileo