Bug#554790: This breaks device.map on upgrade

Colin Watson cjwatson at ubuntu.com
Tue Jul 20 16:16:43 UTC 2010


On Tue, Jul 20, 2010 at 03:02:47PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 07/12/2010 12:38 PM, Colin Watson wrote:
> >> Vladimir, would this patch need a copyright assignment?  Most of it
> >> seems pretty straightforward; in fact I doubt that it would come out
> >> very much different if I'd written it from scratch.
> 
> No need of copyright assignment for this patch.
> 
> > 2010-07-12  Vadim Solomin  <vadic052 at gmail.com>
> > 2010-07-12  Colin Watson  <cjwatson at ubuntu.com>
> >
> > 	Generate device.map in something closer to the old ordering.
> >
> > 	* util/deviceiter.c (struct device): New declaration.
> > 	(compare_file_names): Rename to ...
> > 	(compare_devices): ... this.  Sort by kernel name in preference
> > 	to the stable by-id name, but keep the latter as a fallback
> > 	comparison.  Update header comment.
> > 	(grub_util_iterate_devices) [__linux__]: Construct and sort an
> > 	array of `struct device' rather than of plain file names.
> 
> Go ahead.

OK, committed.  Thanks.

-- 
Colin Watson                                       [cjwatson at ubuntu.com]





More information about the Pkg-grub-devel mailing list