[Pkg-gtkpod-devel] Missing commits for libplist
Boyuan Yang
byang at debian.org
Mon Jan 7 14:20:52 GMT 2019
Hi,
在 2019-01-07一的 14:28 +0100,Yves-Alexis Perez写道:
> I've pushed some more changes (as well on libimobiledevice) to fix an issue
> with FORTIFY beeing ignored (it was actually all CPPFLAGS which were
> ignored).
>
> I'd be able to have a quick review before uploading, but if you don't have
> time just tell me and I will go ahead.
I just took a look; it looks generally okay except several following issues:
* For libimobiledevice, an upstream tag is missing and you listed
1.2.1~git20190401.92c5462-1 as new upload version in d/changelog. I guess it
should be 20190104; besides, it might be a better idea to use the date of
latest upstream commit, which is 20181030 instead.
* We may record the new "upstream" tarball in the git repo later using
pristine-tar branch. This is just a recommendation, not a bug.
--
Thanks,
Boyuan Yang
More information about the Pkg-gtkpod-devel
mailing list