[Pkg-gtkpod-devel] Missing commits for libplist

[Yves-Alexis Perez]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Mon, 2019-01-07 at 09:20 -0500, Boyuan Yang wrote:
> I just took a look; it looks generally okay except several following issues:

Thanks for the review.
> 
> * For libimobiledevice, an upstream tag is missing

Indeed.

>  and you listed
> 1.2.1~git20190401.92c5462-1 as new upload version in d/changelog. I guess it
> should be 20190104; 

Indeed, I messed up the tag name actually.

> besides, it might be a better idea to use the date of
> latest upstream commit, which is 20181030 instead.

I have no hard feeling on it. Since I've messed it up, I'll redo it that way.
> 
> * We may record the new "upstream" tarball in the git repo later using
> pristine-tar branch. This is just a recommendation, not a bug.

I forgot to push the pristine-tar branch as well, so I'll do that as well.

By the way, right now I'm doing a git merge of the manually tagged stuff in
the upstream branch, but it would apparently be possible to do a gbp import-
orig --uscan provided debian/watch has the correct stuff in it. Do you have an
idea of the right syntax for that?

Regards,
- -- 
Yves-Alexis
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAlwzZTIACgkQ3rYcyPpX
RFv2cwgApirRIptew3dbRmzKKpNxcyGsExY6gNfWGVlk2awYe2L2rAt3E2CG1vGT
6AfGEuh5/IUtov8uCLxZJcAKhXc3Gzy8GMYljyN9zFGWl73e+jsrB1d10+bTQigo
72x4KRG/Glc5D5nKJDE7jM80k5SGN9wfo3S+ibLXmJwqHxHc2dh2rPNRa8vY2rgo
2pieLzy9sCAbhZNXnJ4DPHtmheGbd54J+5gEzQ8PYoAk2MMVBctYewcn7BEdY9NZ
sgKsADGgGgZCJiMq9qZBamNOEtFlZpGb+5ZnlRabYvj/6dv+zohM0Y9U3+12AMtv
kUM55HxB702B+ACbm14F6hJ74zZzdA==
=gYrs
-----END PGP SIGNATURE-----