[Pkg-gtkpod-devel] Missing commits for libplist

Boyuan Yang byang at debian.org
Mon Jan 7 14:46:55 GMT 2019


在 2019-01-07一的 15:41 +0100,Yves-Alexis Perez写道:
> On Mon, 2019-01-07 at 09:20 -0500, Boyuan Yang wrote:
> > I just took a look; it looks generally okay except several following
> > issues:
> 
> Thanks for the review.
> > * For libimobiledevice, an upstream tag is missing
> 
> Indeed.
> 
> >  and you listed
> > 1.2.1~git20190401.92c5462-1 as new upload version in d/changelog. I guess
> > it
> > should be 20190104; 
> 
> Indeed, I messed up the tag name actually.
> 
> > besides, it might be a better idea to use the date of
> > latest upstream commit, which is 20181030 instead.
> 
> I have no hard feeling on it. Since I've messed it up, I'll redo it that
> way.
> > * We may record the new "upstream" tarball in the git repo later using
> > pristine-tar branch. This is just a recommendation, not a bug.
> 
> I forgot to push the pristine-tar branch as well, so I'll do that as well.
> 
> By the way, right now I'm doing a git merge of the manually tagged stuff in
> the upstream branch, but it would apparently be possible to do a gbp import-
> orig --uscan provided debian/watch has the correct stuff in it.

I'd recommend using gbp import-orig --uscan --pristine-tar to automatically
generate pristine-tar branch from upstream tarballs when applicable.

>  Do you have an
> idea of the right syntax for that?

Once upstream tags a new version and we decide to use upstream-provided
tarball, I guess it's just some standard stuff as documented in uscan(1). Is
there any certain concerns with it?

--
Thanks,
Boyuan Yang




More information about the Pkg-gtkpod-devel mailing list