[testng] 224/355: Remove preserveOrderAnna from PreserveOrderTest

[Eugene Zhukov]

This is an automated email from the git hooks/post-receive script.

eugene-guest pushed a commit to annotated tag OpenBSD
in repository testng.

commit 04687ed8d0519ec29a3b33942fa638743633a4f5
Author: Ryan Schmitt <rschmitt at pobox.com>
Date:   Fri Apr 24 23:42:01 2015 -0700

    Remove preserveOrderAnna from PreserveOrderTest
    
    Annotation-driven discovery of test methods is backed by
    Class#getDeclaredMethods, which returns methods in an undefined order.
    This is explained by the Javadoc for that method, which states that "The
    elements in the returned array are not sorted and are not in any
    particular order." Consequently, this test has undefined behavior and
    may pass or fail nondeterministically, which is exactly what I've been
    observing with various releases of JDK8.
    
    Fixes #582.
---
 .../java/test/preserveorder/PreserveOrderTest.java | 53 ----------------------
 1 file changed, 53 deletions(-)

diff --git a/src/test/java/test/preserveorder/PreserveOrderTest.java b/src/test/java/test/preserveorder/PreserveOrderTest.java
index 3ac14cc..c5a6f8e 100644
--- a/src/test/java/test/preserveorder/PreserveOrderTest.java
+++ b/src/test/java/test/preserveorder/PreserveOrderTest.java
@@ -3,9 +3,7 @@ package test.preserveorder;
 import org.testng.Assert;
 import org.testng.TestListenerAdapter;
 import org.testng.TestNG;
-import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
-import org.testng.collections.Lists;
 import org.testng.xml.XmlClass;
 import org.testng.xml.XmlSuite;
 import org.testng.xml.XmlTest;
@@ -108,57 +106,6 @@ public class PreserveOrderTest extends SimpleBaseTest {
         "c3TestOne", "c3TestTwo", "c3TestThree");
   }
 
-  @Test(dataProvider = "dp")
-  public void preserveOrderAnna(String[] classes, String[] expectedMethods) {
-    TestNG tng = create();
-    XmlSuite s = createXmlSuite("PreserveOrder");
-    XmlTest t = new XmlTest(s);
-
-    for (String c : classes) {
-      t.getXmlClasses().add(new XmlClass("test.preserveorder." + c));
-    }
-    t.setPreserveOrder("true");
-
-    tng.setXmlSuites(Arrays.asList(s));
-    TestListenerAdapter tla = new TestListenerAdapter();
-    tng.addListener(tla);
-    tng.run();
-
-    try {
-      verifyPassedTests(tla, expectedMethods);
-    } catch(Exception ex) {
-      ex.printStackTrace();
-    }
-  }
-
-  @DataProvider
-  public Object[][] dp() {
-    String[][] classes = new String[][] {
-        { "PrgTest", "SibTest", "EdnTest" },
-        { "PrgTest", "EdnTest", "SibTest" },
-        { "SibTest", "PrgTest", "EdnTest" },
-        { "SibTest", "EdnTest", "PrgTest" },
-        { "EdnTest", "PrgTest", "SibTest" },
-        { "EdnTest", "SibTest", "PrgTest" },
-    };
-    String[][] expectedMethods = new String[][] {
-        { "prg1", "prg2", "sib1", "sib2", "edn1", "edn2" },
-        { "prg1", "prg2", "edn1", "edn2", "sib1", "sib2" },
-        { "sib1", "sib2", "prg1", "prg2", "edn1", "edn2" },
-        { "sib1", "sib2", "edn1", "edn2", "prg1", "prg2" },
-        { "edn1", "edn2", "prg1", "prg2", "sib1", "sib2" },
-        { "edn1", "edn2", "sib1", "sib2", "prg1", "prg2" },
-    };
-
-    List<Object[]> result = Lists.newArrayList();
-    for (int i = 0; i < classes.length; i++) {
-      Object[] o = new Object[] { classes[i], expectedMethods[i] };
-      result.add(o);
-    }
-
-    return result.toArray(new Object[result.size()][]);
-  }
-
   @Test(description = "preserve-order on a factory doesn't cause an NPE")
   public void factoryPreserve() {
     TestNG tng = create();

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-java/testng.git