Bug#954662: obantoo: Obantoo includes an outdated BLZ.txt

[tony mancill]

On Sun, Mar 22, 2020 at 01:49:06PM +0100, Thomas Weber wrote:
> Source: obantoo
> Severity: normal
> 
> The current version of BLZ.txt in the package dates from 2015, which
> means that checks for new BLZs and IBANs based on them will fail (e.g.
> 59020400). While the Deutsche Bundesbank makes available updated BLZ.txt
> files for free on their website, obantoo uses the extended version
> ("erweiterte Bankleitzahlendatei"), which is only available with an
> account on their Extranet[1]. I have applied for an account, but have
> not yet received an answer. However, a recent version of BLZ.txt has
> been added by the Hibiscus author and can be extracted from [2]. 
> 
> I prepared a patch based on [2], but the resulting diff is 6 MB in size
> - which is suboptimal. I do not have a really good proposal on how to
> move forward here, but given that an updated BLZ.txt is published every
> quarter, it seems suboptimal to put it into the JAR file: 
>   1) This makes it unneccessarily difficult to find the file and replace
>   it with a local version.
>   2) It requires a new release of the software when it reality there
>   were no code changes and only a data update.
> 
> [1] https://www.bundesbank.de/de/aufgaben/unbarer-zahlungsverkehr/serviceangebot/bankleitzahlen/bankleitzahlen-602638
> [2] https://github.com/willuhn/hibiscus/raw/master/lib/obantoo-bin-2.1.12.jar

Hi Thomas,

It sounds like you are proposing creating a separate "obantoo-data"
package that is updated regularly.

Fortunately there is only place in the source code that references the
data file [3] (and then a few further lines down for the CSV file for
Austria [4]), and it wouldn't be too difficult to write a patch to
source these files from the file system.  If we decide to go this path,
we'll want to exclude the data files from the obantoo sources when we
repack the source archive. (Otherwise we would end up with a large diff
to represent the deletions.)

Does that sound like a reasonable solution?  I can help with patch for
obantoo if that's helpful.

Cheers,
tony

[3] https://salsa.debian.org/java-team/obantoo/-/blob/master/src/de/jost_net/OBanToo/SEPA/BankenDaten/Banken.java#L30
[4] https://salsa.debian.org/java-team/obantoo/-/blob/master/src/de/jost_net/OBanToo/SEPA/BankenDaten/Banken.java#L47
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-java-maintainers/attachments/20200327/1567710b/attachment.sig>