[Pkg-javascript-commits] [dojo] 77/88: Fixes #16833. Use removeNode on IE to avoid leaks when event handlers are on the node and removeChild everywhere else. Backport thru 1.6. !strict

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to annotated tag 1.8.5
in repository dojo.

commit 336b3594bf7186e72e079157fbd9350f01ad0299
Author: Douglas Hays <doughays at dojotoolkit.org>
Date:   Wed Mar 27 22:19:40 2013 +0000

    Fixes #16833.  Use removeNode on IE to avoid leaks when event handlers are on the node and removeChild everywhere else.  Backport thru 1.6. !strict
    
    git-svn-id: http://svn.dojotoolkit.org/src/branches/1.8/dojo@31027 560b804f-0ae3-0310-86f3-f6aa0a117693
---
 dom-construct.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dom-construct.js b/dom-construct.js
index 61af1ae..b9b8bf8 100644
--- a/dom-construct.js
+++ b/dom-construct.js
@@ -299,7 +299,8 @@ define(["exports", "./_base/kernel", "./sniff", "./_base/window", "./dom", "./do
 			_empty(node);
 		}
 		if(parent){
-			parent.removeChild(node);
+			// removeNode(false) doesn't leak in IE 6+, but removeChild() and removeNode(true) are known to leak under IE 8- while 9+ is TBD
+			has("ie") ? node.removeNode(false) : parent.removeChild(node);
 		}
 	}
 	exports.destroy = function destroy(/*DOMNode|String*/ node){

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/dojo.git