[Pkg-javascript-commits] [dojo] 78/88: Refs #16833. svg nodes do not have a removeNode method, but don't seem to leak either with removeChild. !strict

David Prévot taffit at moszumanska.debian.org
Thu Aug 21 17:39:41 UTC 2014


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to annotated tag 1.8.5
in repository dojo.

commit 7d488ff7b8c1224cfcd0e8db94ee917c996d684a
Author: Douglas Hays <doughays at dojotoolkit.org>
Date:   Thu Mar 28 13:15:40 2013 +0000

    Refs #16833.  svg nodes do not have a removeNode method, but don't seem to leak either with removeChild. !strict
    
    git-svn-id: http://svn.dojotoolkit.org/src/branches/1.8/dojo@31049 560b804f-0ae3-0310-86f3-f6aa0a117693
---
 dom-construct.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dom-construct.js b/dom-construct.js
index b9b8bf8..fc7b539 100644
--- a/dom-construct.js
+++ b/dom-construct.js
@@ -300,7 +300,7 @@ define(["exports", "./_base/kernel", "./sniff", "./_base/window", "./dom", "./do
 		}
 		if(parent){
 			// removeNode(false) doesn't leak in IE 6+, but removeChild() and removeNode(true) are known to leak under IE 8- while 9+ is TBD
-			has("ie") ? node.removeNode(false) : parent.removeChild(node);
+			has("ie") && 'removeNode' in node ? node.removeNode(false) : parent.removeChild(node);
 		}
 	}
 	exports.destroy = function destroy(/*DOMNode|String*/ node){

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/dojo.git



More information about the Pkg-javascript-commits mailing list