[Pkg-javascript-commits] [dojo] 49/149: Fix ready() helper to avoid prematurely reporting the page is ready.

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository dojo.

commit 1f31dd4d98ddc6aef003eb0e1a1e2ee34bdc97d3
Author: Bill Keese <bill at dojotoolkit.org>
Date:   Wed Mar 18 09:57:14 2015 +0900

    Fix ready() helper to avoid prematurely reporting the page is ready.
    
    Test files often say "var ready = false", but the callback to pollUntil()
    needs to return undefined, not false.
    
    Rfs #18427.
---
 tests/support/ready.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/support/ready.js b/tests/support/ready.js
index b8d1b27..5a3c0fd 100644
--- a/tests/support/ready.js
+++ b/tests/support/ready.js
@@ -5,7 +5,7 @@ define([
 		return remote
 			.get(url)
 			.then(pollUntil(
-				'return typeof ready !== "undefined" ? ready : null;',
+				'return typeof ready !== "undefined" && ready ? true : undefined;',
 				[],
 				typeof timeout === 'undefined' ? 5000 : timeout
 			));

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/dojo.git