[Pkg-javascript-devel] Please review libjs-jquery-coolfieldset

[Marcelo Jorge Vieira]

Hi,

On Fri, 2014-03-07 at 17:33 +0100, François-Régis wrote:
> Hi everybody,
> 
> Could anybody have a look at libjs-jquery-coolfieldset [1], it's my
> first js package so please look it closely...
> 
> Any comment, suggestion or insult are welcome ;=)
> 
> [1]
> http://anonscm.debian.org/gitweb/?p=pkg-javascript/libjs-jquery-coolfieldset.git


This is a small JS file, IMHO you should to include it in the
jquery-goodies package [0].

[0] http://anonscm.debian.org/gitweb/?p=pkg-javascript/jquery-goodies.git


A little review:

1) Could you rename the source package and repository to
jquery-coolfieldset?

2) The upstream tarball include the minified version of jQuery, you
should remove it.

3) Copyright: Please include debian/* section with your name, etc.

4) The debian/docs file is empty, so remove it.

5) debian debian/README.source, please write something or remove it.

6) Rules: Once you took over the lib, why didn't you fix the permission
of jquery.coolfieldset.js in the upstream side instead of fixing it in
rules?


That's it for now, if you have any questions, please don't hesitate to
contact the JavaScript team list.


Cheers,

-- 
Marcelo Jorge Vieira
xmpp:metal at jabber-br.org
http://metaldot.alucinados.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/attachments/20140316/5ef17cbd/attachment.sig>