[Pkg-javascript-devel] Please review libjs-jquery-coolfieldset

[François-Régis]

Le 17/03/2014 00:17, Marcelo Jorge Vieira a écrit :
> Hi,
> 
> On Fri, 2014-03-07 at 17:33 +0100, François-Régis wrote:
>> Hi everybody,
>>
>> Could anybody have a look at libjs-jquery-coolfieldset [1], it's my
>> first js package so please look it closely...
>>
>> Any comment, suggestion or insult are welcome ;=)
>>
>> [1]
>> http://anonscm.debian.org/gitweb/?p=pkg-javascript/libjs-jquery-coolfieldset.git
> 
> 
> This is a small JS file, IMHO you should to include it in the
> jquery-goodies package [0].
> 
> [0] http://anonscm.debian.org/gitweb/?p=pkg-javascript/jquery-goodies.git

It's a great idea, This piece of JS is a dependency for fusionforge
(that's why I'm packaging it). Just let me now what to to do to include it.
> 
> A little review:
> 
> 1) Could you rename the source package and repository to
> jquery-coolfieldset?

Yes done.

> 
> 2) The upstream tarball include the minified version of jQuery, you
> should remove it.

Actually I don't install it but I keep it in the pristine tarball. But
see below 6)
> 
> 3) Copyright: Please include debian/* section with your name, etc.

> 
> 4) The debian/docs file is empty, so remove it.

Done


> 5) debian debian/README.source, please write something or remove it.

Done

> 6) Rules: Once you took over the lib, why didn't you fix the permission
> of jquery.coolfieldset.js in the upstream side instead of fixing it in
> rules?

I'm waiting for an uptsream author response on how he wants to maintain
this plugin, so I tried to stick on the upstream sources to avoid a fork.

He does'nt seem to care much about this plugin (does not reply to my
mails and no replies to important bug fixes since 2011).

So should I realy overtaking the (little) lib and strip jaquery minify
from tarballl, change fix permissions etc. as an uptream for debian ?

This is a small piece of software and if it'included in jquery-goodies
package this very ok for me
 >
> 
> That's it for now, if you have any questions, please don't hesitate to
> contact the JavaScript team list.

Waiting for your advices,

-- 
François-Régis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 880 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/attachments/20140318/f49adc76/attachment.sig>