[Pkg-javascript-devel] RFS: node-i18next-xhr-backend and node-i18next-browser-languagedetector

[Xavier]

Le 01/12/2019 à 16:02, Nicolas Mora a écrit :
> Hello Team,
> 
> I'm looking for a DD to review my 2 i18next* packages, and upload them
> to NEW if they meet Debian quality level:
> 
> - node-i18next-xhr-backend: simple i18next backend to be used in the
> browser - https://salsa.debian.org/js-team/node-i18next-xhr-backend
> 
> - node-i18next-browser-languagedetector: i18next language detection
> plugin use to detect user language in the browser -
> https://salsa.debian.org/js-team/node-i18next-browser-languagedetector
> 
> I applied the same changes that were made in the node-i18next package
> which was recently uploaded to unstable, aka splitting the binary
> package in 2: a node and a libjs package
> 
> Thanks in advance
> 
> /Nicolas

Not good:
 * remove *.min.js from import (or if not used, at least update lintian
   overrides with a comment)
 * dependency:
   - node-i18* depends on libjs-i18*, not the reverse	
   - libjs-i18next-xhr-backend must not depend on any node*
   - libjs-i18* should "Recommends: javascript-common"
 * switch to debhelper-compat
 * debhelper-compat 12, not 11
 * add "Rules-Requires-Root: no" in Debian control