[Pkg-javascript-devel] RFS: node-i18next-xhr-backend and node-i18next-browser-languagedetector

Nicolas Mora nicolas at babelouest.org
Sun Dec 1 19:16:33 GMT 2019


Le 19-12-01 à 11 h 32, Xavier a écrit :
> Le 01/12/2019 à 16:02, Nicolas Mora a écrit :

>> I'm looking for a DD to review my 2 i18next* packages, and upload them
>> to NEW if they meet Debian quality level:
>>
> 
> Not good:
>  * remove *.min.js from import (or if not used, at least update lintian
>    overrides with a comment)
Fixed, added in lintian-overrides (although I still don't understand why
I didn't have the lintian warning...)

>  * dependency:
>    - node-i18* depends on libjs-i18*, not the reverse	
>    - libjs-i18next-xhr-backend must not depend on any node*
My very bad, fixed

>    - libjs-i18* should "Recommends: javascript-common"
done

>  * switch to debhelper-compat
done

>  * debhelper-compat 12, not 11
done

>  * add "Rules-Requires-Root: no" in Debian control
done



More information about the Pkg-javascript-devel mailing list