[Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

[Pirate Praveen]

On Mon, Oct 7, 2019 at 18:32, Nicolas Mora <nicolas at babelouest.org> 
wrote:
> Indeed it's just warning messages, I've read the build log too fast, 
> the
> error was because of invalid tests.
> The upstream package uses karma to run tests so I had to disable 
> testing
> in the package build. I let a note as a reminder for the future in
> debian/tests/pkg-js/test
> 
> I've made other changes in the package to use pkg-js-tools features.

* You can change pkg-js-tools dependency to (>= 0.8.13~) and then 
remove debian/install file.

* You remove unnecessary comments like #override.. #export... in rules.

* It is better to remove debian/tests/pkg-js/test instead of creating a 
dummy script. You can ignore that lintian warning (it makes it easy to 
know if a package is not running tests). Since no tests are run 
node-tape could be removed from build dependencies.

* You can push to https://salsa.debian.org/js-team/node-i18next/ after 
squashing related commits.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20191008/9b34cd91/attachment.html>