[Pkg-javascript-devel] build node-i18next with webpack instead or rollup?

[Nicolas Mora]

Hello,

Le 19-10-08 à 03 h 57, Pirate Praveen a écrit :
> 
> * You can change pkg-js-tools dependency to (>= 0.8.13~) and then remove
> debian/install file.
> 
done

> * You remove unnecessary comments like #override.. #export... in rules.
> 
done

> * It is better to remove debian/tests/pkg-js/test instead of creating a
> dummy script. You can ignore that lintian warning (it makes it easy to
> know if a package is not running tests). Since no tests are run
> node-tape could be removed from build dependencies.
> 
done

> * You can push to https://salsa.debian.org/js-team/node-i18next/ after
> squashing related commits.
> 
done
although I didn't squash the commits in the master branch, only pushed
as it is in my personnal repo. Should I rebase all the commits in the
master branch from the start?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 2460 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20191008/d91291f3/attachment.key>