[Pkg-javascript-devel] Babel

[Xavier]

Le 30/08/2019 à 16:40, Nilesh Patra a écrit :
> 
>     Hi,
> 
>     OK for removing the patch.
> 
>     You removed debian/install without adding pkg-js-tools needed entries
>     (d/control & d/rules), then your package is empty.
> 
>     Cheers,
>     Xavier
> 
> Hi
> I have rectified the issues. Could you review, if everything looks okay?

Hi,

 * install: good, just to set a minimal version for pkg-js-tools to help
            backports (0.9 at least)

 * tests: you didn't use pkg-js-tools for tests, then your autopkgtest
          tests are bad. Todo:
           $ mkdir -p debian/tests/pkg-js
           $ git rm debian/tests/{control,require}
           $ echo 'tap test/*.js' > debian/tests/pkg-js/test
           $ git add debian/tests/pkg-js/test
   Then remove override_dh_auto_test entry from debian/rules, add
   missing "Testsuite: autopkgtest-pkg-nodejs" in debian/control and
   commit

 * clean: you used an override_dh_auto_clean to remove on file, then
          dh_auto_test is disabled. This is not a good practice. Prefer
          to use a debian/clean file:
           $ echo 'debian/semver.1' > debian/clean
           $ git add debian/clean
   Then remove override_dh_auto_test from debian/rules and commit

 * links: you didn't take a look at your package (using debc), you have
          2 bad symlinks. To fix that (only one is needed):
        $ echo 'semver/bin/semver /usr/bin/semver' > debian/nodejs/links

Then commit your changes in js-team/node-semver