[Pkg-javascript-devel] Babel

[Nilesh Patra]

Hi

>   * install: good, just to set a minimal version for pkg-js-tools to help
>             backports (0.9 at least)
>
>  * tests: you didn't use pkg-js-tools for tests, then your autopkgtest
>           tests are bad. Todo:
>            $ mkdir -p debian/tests/pkg-js
>            $ git rm debian/tests/{control,require}
>            $ echo 'tap test/*.js' > debian/tests/pkg-js/test
>            $ git add debian/tests/pkg-js/test
>    Then remove override_dh_auto_test entry from debian/rules, add
>    missing "Testsuite: autopkgtest-pkg-nodejs" in debian/control and
>    commit
>
>  * clean: you used an override_dh_auto_clean to remove on file, then
>           dh_auto_test is disabled. This is not a good practice. Prefer
>           to use a debian/clean file:
>            $ echo 'debian/semver.1' > debian/clean
>            $ git add debian/clean
>    Then remove override_dh_auto_test from debian/rules and commit
>
>  * links: you didn't take a look at your package (using debc), you have
>           2 bad symlinks. To fix that (only one is needed):
>         $ echo 'semver/bin/semver /usr/bin/semver' > debian/nodejs/links
>
> Then commit your changes in js-team/node-semver
>

I have done the changes. Could you please review, if it looks okay? I also
don't have access to js-team/node-semver, please grant me so that I may
push.
I also had a doubt:
I read the man pages, I kind of get an idea, but could you explain how debc
works, and how I can check bad symlinks (I am not sure about this one,
since doing debc on changes file didn't show bad links before)  ?
That would be great.

Thanks and Regards
Nilesh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20190831/3ac28bd1/attachment.html>