[Pkg-javascript-devel] [RFS] node-jsonld

[Jonas Smedegaard]

Quoting Nilesh Patra (2020-02-02 16:01:57)
> I fixed node-jsonld to build with Node.js >= 12. It builds fine in a clean
> chroot, and autopkgtests pass.
> (Didn't use pkg-js-tools since I'm unsure if I should embed modules only
> for test).
> I have pushed my changed here[1].
> (Didn't push to js-team since I was unsure of the changes)
> Needs review and sponsorship.

Thanks!

I have merged the parts I found sensible, but it fails for me to build 
in unstable (did you perhaps intend for it to be targeted experimental 
instead?).

I skipped your bumping debhelper compatibility level: I don't like to 
blindly doing that, so please tell which actual feature you find is the 
reason for such change.  I recommend to generally mention reasoning when 
bumping debhelper compatibility level.

I skipped your adding metadata which to me seem all duplicates of 
information already in debian/copyright.  Please clarify (I may very 
well have missed something).

I reduced your module resolving patch to only add /usr/share/nodejs - if 
the two relative paths ('.' and 'node_modules') are really needed then 
please explain why (again, I may very well have missed something, but it 
looks to me like a dirty hack which might cause trouble at least on 
non-clean build environments).


Regards,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20200202/5b18e333/attachment.sig>