[Pkg-javascript-devel] [RFS] node-jsonld

[Nilesh Patra]

On Sun, 2 Feb 2020 at 22:48, Jonas Smedegaard <jonas at jones.dk> wrote:

> Quoting Nilesh Patra (2020-02-02 16:01:57)
> > I fixed node-jsonld to build with Node.js >= 12. It builds fine in a
> clean
> > chroot, and autopkgtests pass.
> > (Didn't use pkg-js-tools since I'm unsure if I should embed modules only
> > for test).
> > I have pushed my changed here[1].
> > (Didn't push to js-team since I was unsure of the changes)
> > Needs review and sponsorship.
>
> Thanks!
>
> I have merged the parts I found sensible,


Thank you, :)


> but it fails for me to build
> in unstable (did you perhaps intend for it to be targeted experimental
> instead?).
>

Well, it does seem to build fine for me. Sharing the logs[1]. Not sure why
that fails for you.
Do let me know if it is a mistake at my end.

[1]: https://git.fosscommunity.in/gi-boi/build-logs/blob/master/jsonld.txt

I skipped your bumping debhelper compatibility level: I don't like to
> blindly doing that, so please tell which actual feature you find is the
> reason for such change.  I recommend to generally mention reasoning when
> bumping debhelper compatibility level.
>

I bumped it because it is the newer suggested compatibility version, and
lintian suggested doing that as well.
I don't have any other reason for doing that.


> I skipped your adding metadata which to me seem all duplicates of
> information already in debian/copyright.  Please clarify (I may very
> well have missed something).
>

Noted this point(to check d/copyright). I included it because I have seen
it in a good number of packages.
Lintian adviced me to do that as well, so added that in. Apologies if these
two changes shouldn't have been done.

I reduced your module resolving patch to only add /usr/share/nodejs - if
> the two relative paths ('.' and 'node_modules') are really needed then
> please explain why (again, I may very well have missed something, but it
> looks to me like a dirty hack which might cause trouble at least on
> non-clean build environments).
>

I have faced issues with webpack failing to resolve modules when they are
embedded.
I added that in to avoid webpack failing to recognize those, if in case
modules are embedded in future.


> Regards,
>
>  - Jonas
>
> --
>  * Jonas Smedegaard - idealist & Internet-arkitekt
>  * Tlf.: +45 40843136  Website: http://dr.jones.dk/
>
>  [x] quote me freely  [ ] ask before reusing  [ ] keep private
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20200202/2582e3fd/attachment.html>