[Pkg-javascript-devel] babel 7.9.6 update

[Xavier]

Le 06/06/2020 à 09:41, Xavier a écrit :
> Le 05/06/2020 à 21:37, Xavier a écrit :
>> Hi,
>>
>> node-rollup-plugin-babel tests are broken by babel 7.9.6 (autopkgtest
>> only: no test during build to avoid circular deps). Here is the
>> difference with `npm i` (given by my debug tools). It's the only one bug
>> I found when trying to update babel. Could someone take a look?
>>
>> The error is:
>>
>>   /usr/share/nodejs/yargs/yargs.js:1242
>>         else throw err
>>              ^
>>   TypeError: Cannot read property 'type' of null
> 
> Update:
>  * test passed with a copy of some /usr/share/nodejs/@babel modules in
>    node_modules [2] (with a little patch [1])
>  * when removing some of them (example with
>    @babel/helper-create-class-features-plugin), I got a similar but
>    different error:
> 
>       1) rollup-plugin-babel
>            works with proposal-decorators (#18):
>          TypeError: Cannot read property 'type' of null
> 
> Problem exists only with node-babel7 7.9.6, not with 7.4.5
> 
> There is nothing strange in test/**/.babelrc
> 
> [1]:
> https://salsa.debian.org/js-team/node-rollup-plugin-babel/-/blob/master/debian/patches/fix-test-for-babel-7.9.6.diff
> 
> [2]: core helper-create-class-features-plugin
> helper-create-regexp-features-plugin plugin-external-helpers
> plugin-proposal-async-generator-functions plugin-proposal-decorators
> plugin-proposal-nullish-coalescing-operator
> plugin-proposal-object-rest-spread plugin-proposal-optional-chaining
> plugin-proposal-unicode-property-regex
> plugin-transform-async-to-generator
> plugin-transform-block-scoped-functions plugin-transform-block-scoping
> plugin-transform-classes plugin-transform-computed-properties
> plugin-transform-destructuring plugin-transform-dotall-regex
> plugin-transform-duplicate-keys plugin-transform-exponentiation-operator
> plugin-transform-for-of plugin-transform-member-expression-literals
> plugin-transform-modules-amd plugin-transform-modules-commonjs
> plugin-transform-modules-systemjs plugin-transform-modules-umd
> plugin-transform-named-capturing-groups-regex
> plugin-transform-new-target plugin-transform-object-super
> plugin-transform-parameters plugin-transform-property-literals
> plugin-transform-reserved-words plugin-transform-runtime
> plugin-transform-shorthand-properties plugin-transform-spread
> plugin-transform-sticky-regex plugin-transform-template-literals
> plugin-transform-typeof-symbol plugin-transform-unicode-regex preset-env

Hi,

After some tries, our babel 7.9.6 has the same behavior than `npm i`
downloaded one. So I prepared a workaround:
 * use debian/nodejs/extcopies (with a little change in pkg-js-tools to
   avoid an error with babel 7.4.5 ; => pkg-js-tools_0.9.37)
 * add a little patch to be compatible with babel 7.9.6 error messages

I'm ready to upload both node-rollup-plugin-babel and pkg-js-tools,
waiting for eventual comments (all is pushed to salsa)