[Pkg-javascript-devel] Bug#1004471: Bug#1004471: Pending patch for terser-webpack-plugin in webpack 5 till a new upstream for node-terser is uploaded

[Caleb Adepitan]

Sorry for the confusion I've caused. I was hoping mentioning that 
"terser-webpack-plugin embedded in webpack package" in the initial 
wishlist bug report 
(https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1004471) stays 
relevant in subsequent discussions under the report.

I probably shouldn't have shared a patch intended for node-webpack 
(terser-webpack-plugin) under a bug filed for node-terser. I only 
thought since the report mentioned that the bug affects webpack it would 
be fine to add some additional info about a pending patch to affected 
packages till the node-terser package is updated. It might help to later 
  know that when node-terser gets updated and the wishlist bug is 
closed, the patch should become irrelevant and be removed from the 
affected package.

The patch intended no changes to node-terser, only the packages affected 
by an incompatible version of node-terser which as I mentioned was 
terser-webpack-plugin embedded in webpack 5.

The only changes intended for node-terser package as mentioned by the 
wishlist bug is to update node-terser to latest upstream, terser 5.

Thanks for taking the time,

Caleb


On 2/5/22 4:04 PM, Jonas Smedegaard wrote:
> Quoting Caleb Adepitan (2022-02-05 11:42:51)
>>
>>
>> On 2/4/22 3:45 PM, Jonas Smedegaard wrote:
>>> Quoting Caleb Adepitan (2022-02-04 08:46:29)
>>>> I just arrived at a working patch for terser-webpack-plugin to
>>>> circumvent breaking changes in node-terser 5 which is required by
>>>> the package. The available version of node-terser in debian is 4
>>>> which is behind the terser package upstream.
>>>>
>>>> This patch is an ad-hoc fix for the bug pending the node-terser
>>>> package is updated to a compatible version.
>>>
>>> This _relates_ to NodeJS module terser, but is it most specifically
>>> tied to terser, webpack, or terser-webpack-plugin?
>>>
>>> You post the above to bug#1004471 which is tied to Debian package
>>> node-terser, but your presented patch seems not for terser but for
>>> something else - webpack or terser-webpack-plugin.
>>>
>>> Helpful if you can clarify further what fixes what (not only for
>>> what end goal).
> [...]
>> This affects terser-webpack-plugin which affects webpack 5. This patch
>> relates to *terser-webpack-plugin* (not terser itself) to circumvent
>> breaking changes in terser 5. The current terser-webpack-plugin has
>> been adapted to use terser 5 while the version available to it is
>> terser 4.
>>
>> The patch makes sure terser 4 continues to work with the package while
>> not preventing terser 5 also.
> 
> You continue to talk about some mysterious "terser-webpack-plugin" which
> I fail to locate in Debian, and you do that in a bugreport targeted
> "terser".  Do you see how that is confusing?
> 
> After some investigation (which I had hoped you would have avoided by
> clarifying for me), I discovered that "terser-webpack-plugin" is
> embedded in the Debian package "webpackage".
> 
> I have now filed bug#1005017 regarding the lack of proper hinting about
> that embedded project.  Not your fault that webpack is a mess, but would
> have helped regardless if you had mentioned from a *Debian* viewpoint
> what you were working on (not only from an NPM viewpoint).
> 
> Please, if you want some changes done to the Debian package "terser"
> then clarify what that action is (I don't recognize from the previously
> attached patch what action for the **ter** package is requested).
> 
> Please, if instead you intent no changes for the "terser" package, just
> want to notify about progress elsewhere in the stack, then clarify that.
> 
> 
> Kind regards, and thanks for your work,
> 
>   - Jonas
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x8A1B2CC96775D2D7.asc
Type: application/pgp-keys
Size: 3139 bytes
Desc: OpenPGP public key
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20220205/45f9af6d/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20220205/45f9af6d/attachment.sig>