[Pkg-javascript-devel] Bug#1004471: Bug#1004471: Pending patch for terser-webpack-plugin in webpack 5 till a new upstream for node-terser is uploaded

[Jonas Smedegaard]

Quoting Caleb Adepitan (2022-02-05 17:32:29)
> Sorry for the confusion I've caused. I was hoping mentioning that 
> "terser-webpack-plugin embedded in webpack package" in the initial 
> wishlist bug report 
> (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1004471) stays 
> relevant in subsequent discussions under the report.
> 
> I probably shouldn't have shared a patch intended for node-webpack 
> (terser-webpack-plugin) under a bug filed for node-terser. I only 
> thought since the report mentioned that the bug affects webpack it 
> would be fine to add some additional info about a pending patch to 
> affected packages till the node-terser package is updated. It might 
> help to later know that when node-terser gets updated and the wishlist 
> bug is closed, the patch should become irrelevant and be removed from 
> the affected package.

Interesting reflection.

I cannot say for sure how you might have avoided confusing me - or if 
that is even your responsibility.

I think if you had written less - i.e. left out the patch - then I might 
still have been confused but I might have then simply ignored your post 
as incomprehensible noise, with the result that you would not know that 
I was confused and you would not know that I could be helped if you 
tried clarify.

I think what might have been better was if you had a) filed a separated 
bugreport against webpack, with the patch and a note on how a patch for 
terser-webpack-plugin was relevant to webpack (read: because webpack 
package silently embeds terser-webpack-plugin), and then b) and posted a 
note to this bugreport _about_ the patch (but without including the 
patch itself), mentioning the bugnumber for that other bugreport for 
those curious about the details of that patch.  That way you had shared 
full details but only relevant parts here.

But that is speculation - I might have been confused anyway, for 
whatever reason.  Important is that we figured it out - thanks!  Even 
more important is the work that you do in improving Debian packaging of 
NodeJS modules - regardless if I understand your work - so big thanks 
for that!!


> The patch intended no changes to node-terser, only the packages 
> affected by an incompatible version of node-terser which as I 
> mentioned was terser-webpack-plugin embedded in webpack 5.
> 
> The only changes intended for node-terser package as mentioned by the 
> wishlist bug is to update node-terser to latest upstream, terser 5.

Thanks for clarifying.  Much appreciated!


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20220205/d07336cf/attachment.sig>