[Pkg-javascript-devel] Bug#1068750: moment-timezone.js: FTBFS everywhere

[Santiago Vila]

>> # Fail the build if the tzdata package does not match TZVER.
>> grep -q '^# version 2023d$' /usr/share/zoneinfo/tzdata.zi
> 
> Yes, this is expected after each update to tzdata.
> 
>> I'm curious: Does this package embed the information from tzdata into javascript code,
>> in such a way that a change in tzdata requires a rebuild?
> 
> Yes. It is the only way I found to keep the package aligned with tzdata while ensuring it is fully built from source: upstream ships the pre-compiled tzdata information, so I regenerate those files using the tzdata package.
> 
>> I think it would be highly desirable to find a way for this package to do what
>> it's supposed to do without having to fix it in oldstable and stable every year.
> 
> Without a new upload, I cannot imagine how.. :-/
> 
>> (In fact, I asked Paul Gevers about this, he says that a package which we know
>> for sure that it will fail to build during the support time of the release is RC).
> 
> It fails to build if tzdata is updated, but it never stops working. It just needs to be updated as often as tzdata is. But if you have a suggestion to make this more automatic, I would love to hear it..

Sorry, I still don't get it.

Why does the package build needs to fail if tzdata is updated?

What happens if we allow the package to be built anyway?
(as in the attached patch).

Would the resulting package be broken in any way?

> I have been doing this very repetitive maintenance for years!

Well, I get that you have to make a new upload so that the package is current.
What I don't get is that the package fails to build. At most, it would result
in an improved package, not worse. Or maybe I'm missing anything.

Thanks.
-------------- next part --------------
--- a/debian/control
+++ b/debian/control
@@ -10,6 +10,7 @@ Build-Depends: debhelper-compat (= 13)
  , dh-sequence-nodejs
  , uglifyjs
  , ts-node <!nocheck>
+ , tzdata (>= 2024a)
  , tzdata-legacy (>= 2024a)
 Standards-Version: 4.6.2
 Vcs-Browser: https://salsa.debian.org/js-team/moment-timezone.js
--- a/debian/rules
+++ b/debian/rules
@@ -23,10 +23,6 @@ all: binary
 %:
 	dh $@
 
-execute_before_dh_auto_configure:
-	# Fail the build if the tzdata package does not match TZVER.
-	grep -q '^# version $(TZVER)$$' /usr/share/zoneinfo/tzdata.zi
-
 override_dh_auto_build: $(TARGETS)
 
 execute_before_dh_auto_test: tests/zones/zulu.js