[Pkg-javascript-devel] Bug#1068750: moment-timezone.js: FTBFS everywhere

Martina Ferrari tina at tina.pm
Tue Apr 30 22:41:45 BST 2024


Hi Santiago,

On 30/04/2024 14:01, Santiago Vila wrote:

>> It fails to build if tzdata is updated, but it never stops working. It 
>> just needs to be updated as often as tzdata is. But if you have a 
>> suggestion to make this more automatic, I would love to hear it..
> 
> Sorry, I still don't get it.
> 
> Why does the package build needs to fail if tzdata is updated?

> What happens if we allow the package to be built anyway?
> (as in the attached patch).
> Would the resulting package be broken in any way?

It works, but then there is no way to embed the (effective) tzdata 
version into the moment-timezone.js version, so you could have identical 
source packages producing binaries with the same version and different 
contents, and no way to depend on it. Plus, it almost always fails to 
build anyway, because many of the tests need to be adjusted when tzdata 
changes.

The (better) alternative would be to make it always use a fixed tzdata 
version, but then tzdata migrations will be blocked each time until I 
upload a new version.

>> I have been doing this very repetitive maintenance for years!
> 
> Well, I get that you have to make a new upload so that the package is 
> current.
> What I don't get is that the package fails to build. At most, it would 
> result
> in an improved package, not worse. Or maybe I'm missing anything.

What I described above, but I am really open to suggestions on how to 
better handle this.

-- 
Martina Ferrari



More information about the Pkg-javascript-devel mailing list