[Pkg-javascript-devel] Bug#1017811: node-wikibase-cli: FTBFS without Internet access

[Santiago Vila]

tags 1017811 - moreinfo
reassign 1017811 src:node-wikibase-cli
found 1017811 15.15.4-4
severity 1017811 serious
forcemerge 1017811 1056699 1056708
thanks

Andrius Merkys wrote:
> While this overcomes the FTBFS, this is not the way I would want the
> package to be. It would be much better to find a way to skip tests
> requiring network access and keep the remaining ones to catch possible
> regressions.

Hi.

Your comment above refers to the patch by vorlon where he added "|| true"
after running the tests.

Now I have looked at the code and located all 56 failing tests, then
disabled them using it.skip.

I believe the resulting patch is correct because the output of this command is 56:

grep it.skip debian/patches/disable-remaining-network-tests.patch | wc -l

I pushed this to branch wip-20251026 (note: this was really a mistake,
I meant to push to my private fork, but I can remove the branch at the
end, this is not a big problem).

The package now build from source using the unshare backend:

https://salsa.debian.org/js-team/node-wikibase-cli/-/pipelines/963462

Ok if I upload that?

(There are actually not a lot of tests which do not use the network,
i.e. the difference between this and the original "|| true" is small,
but I believe this is what you had in mind).

Thanks.