[Pkg-javascript-devel] Bug#1017811: node-wikibase-cli: FTBFS without Internet access

[Andrius Merkys]

Hi Santiago,

On 2025-10-26 20:23, Santiago Vila wrote:
> Andrius Merkys wrote:
>> While this overcomes the FTBFS, this is not the way I would want the
>> package to be. It would be much better to find a way to skip tests
>> requiring network access and keep the remaining ones to catch possible
>> regressions.
> 
> Hi.
> 
> Your comment above refers to the patch by vorlon where he added "|| true"
> after running the tests.

ACK.

> Now I have looked at the code and located all 56 failing tests, then
> disabled them using it.skip.

Yes, this is the way I intended it to be.

> I believe the resulting patch is correct because the output of this command is 56:
> 
> grep it.skip debian/patches/disable-remaining-network-tests.patch | wc -l

This seems right. Have you tried building without the internet access?

> I pushed this to branch wip-20251026 (note: this was really a mistake,
> I meant to push to my private fork, but I can remove the branch at the
> end, this is not a big problem).
> 
> The package now build from source using the unshare backend:
> 
> https://salsa.debian.org/js-team/node-wikibase-cli/-/pipelines/963462
> 
> Ok if I upload that?

Yes please. It would be nice to get the wip branch removed from the 
repository once it is merged into master. Thanks a lot for taking care 
of node-wikibase-cli.

> (There are actually not a lot of tests which do not use the network,
> i.e. the difference between this and the original "|| true" is small,
> but I believe this is what you had in mind).

Indeed. I wanted to make sure the package is not completely broken.

Thanks once more!
Andrius