[Pkg-julia-devel] Naming openlibm upstream tarball

[Peter Colberg]

On Tue, Jun 21, 2016 at 04:42:19PM +0200, Graham Inggs wrote:
> The i386 build failed during the tests:
> 
> gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -Wformat
> -Werror=format-security  -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now
> test-double.c -D__BSD_VISIBLE -I ../include -I../src -L.. -lopenlibm
> -Wl,-rpath=/«PKGBUILDDIR» -o test-double
> gcc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -Wformat
> -Werror=format-security  -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now
> test-float.c -D__BSD_VISIBLE -I ../include -I../src -L.. -lopenlibm
> -Wl,-rpath=/«PKGBUILDDIR» -o test-float
> ../libopenlibm.so: undefined reference to `__fpgetprec'

A git bisect found the commit that caused this regression:

commit ebcd40f1b0378522b299bfec63e288df000b43d2
Author: Ed Schouten <ed at nuxi.nl>
Date:   Sun May 15 11:28:26 2016 +0200

    Update remaining references to bsd_cdefs.h to cdefs-compat.h.
    
    It looks like we didn't substitute the name of the bsd_cdefs.h header
    file in two source files when renaming it.

 amd64/bsd_asm.h | 2 +-
 ld80/s_exp2l.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

With that commit reverted, openlibm compiles fine on i386.

The same issue seems to have been reported for Fedora:

https://github.com/JuliaLang/openlibm/issues/117#issuecomment-189658796

> I committed this to git, but I don't mind doing it again if you want to
> re-write history.

I went back by one more upstream version fixing the upstream tags for
0.5.0 and 0.5.1. The debian/watch file was missing repacksuffix to
append "+dfsg" when downloading the tarball with "uscan --rename".

Peter