[Pkg-kde-extras] Bug#906660: kphotoalbum: FTBFS in buster/sid ('QString::QString(const char*)' is private within this context)

[Santiago Vila]

Package: src:kphotoalbum
Version: 5.3-1
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-arch
dh build-arch --parallel --with kf5
   dh_update_autotools_config -a -O--parallel
   dh_auto_configure --buildsystem=kf5 -a -O--parallel
	cd obj-x86_64-linux-gnu && cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON "-GUnix Makefiles" -DCMAKE_BUILD_TYPE=Debian -DCMAKE_INSTALL_SYSCONFDIR=/etc -DKDE_INSTALL_USE_QT_SYS_PATHS=ON ..
-- The C compiler identification is GNU 8.2.0
-- The CXX compiler identification is GNU 8.2.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++

[... snipped ...]

                                                               ^~
/<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.cpp:108:52: error: 'QString::QString(const char*)' is private within this context
                                << ": Received " << qPrintable(id);
                                                    ^~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:47,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QObject:1,
                 from /<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.h:22,
                 from /<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.cpp:19:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:829:5: note: declared private here
     QString(const char *ch);
     ^~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qnamespace.h:43,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs.h:48,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:46,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QObject:1,
                 from /<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.h:22,
                 from /<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.cpp:19:
/<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.cpp:108:63: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]
                                << ": Received " << qPrintable(id);
                                                               ^~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:47,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QObject:1,
                 from /<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.h:22,
                 from /<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.cpp:19:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:829:25: note:   initializing argument 1 of 'QString::QString(const char*)'
     QString(const char *ch);
             ~~~~~~~~~~~~^~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qnamespace.h:43,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs.h:48,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:46,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QObject:1,
                 from /<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.h:22,
                 from /<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.cpp:19:
/<<PKGBUILDDIR>>/RemoteControl/RemoteConnection.cpp:108:52: error: conversion to non-const reference type 'class QString&&' from rvalue of type 'QString' [-fpermissive]
                                << ": Received " << qPrintable(id);
                                                    ^~~~~~~~~~
make[4]: *** [CMakeFiles/kphotoalbum.dir/build.make:2796: CMakeFiles/kphotoalbum.dir/RemoteControl/RemoteConnection.cpp.o] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[3]: *** [CMakeFiles/Makefile2:1183: CMakeFiles/kphotoalbum.dir/all] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[2]: *** [Makefile:144: all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
dh_auto_build: cd obj-x86_64-linux-gnu && make -j1 returned exit code 2
make[1]: *** [debian/rules:11: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:6: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made with "dpkg-buildpackage -B" in my autobuilder.
Most probably, it also fails here in reproducible builds:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/kphotoalbum.html

where you can get a full build log if you need it.

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.