[Pkg-kde-extras] Bug#900008: kid3 FTCBFS: multiple reasons

[Helmut Grohne]

Source: kid3
Version: 3.5.1-1
Tags: patch
User: helmutg at debian.org
Usertags: rebootstrap

kid3 fails to cross build from source. The first reason is that it
forces the the build architecture compiler with CMAKE_C_COMPILER and
CMAKE_CXX_COMPILER. It's good that the packaging forwards the
environment variables, but the defaults happen to be the build
architecture compilers and that's wrong for cross compilation.

I thought simply removing them would be a regression, so I went a head
and made debhelper add them in #897083, which got applied to
debhelper/11.3. Thus debhelper will now add these flags for you and you
can drop them in debian/rules.

Now that doesn't quite make it build as it fails running ldd to figure
out prerequisites of a plugin. The CMake GetPrerequisites is probably
unfixable, so I simply ask you to avoid it by making the choice of
ffmpeg explicit with -DWITH_FFMPEG=ON. That way you avoid accidentally
building against gstreamer.

So with these changes kid3 actually cross builds. Can you apply the
attached patch?

Helmut
-------------- next part --------------
diff --minimal -Nru kid3-3.5.1/debian/changelog kid3-3.5.1/debian/changelog
--- kid3-3.5.1/debian/changelog	2017-11-07 10:24:02.000000000 +0100
+++ kid3-3.5.1/debian/changelog	2018-05-24 06:33:47.000000000 +0200
@@ -1,3 +1,12 @@
+kid3 (3.5.1-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Let debhelper pass CMAKE_*_COMPILER.
+    + Explicitly request building with ffmpeg.
+
+ -- Helmut Grohne <helmut at subdivi.de>  Thu, 24 May 2018 06:33:47 +0200
+
 kid3 (3.5.1-1) unstable; urgency=medium
 
   * New upstream release.
diff --minimal -Nru kid3-3.5.1/debian/rules kid3-3.5.1/debian/rules
--- kid3-3.5.1/debian/rules	2017-11-07 10:24:02.000000000 +0100
+++ kid3-3.5.1/debian/rules	2018-05-24 06:33:47.000000000 +0200
@@ -5,7 +5,7 @@
 DEB_CMAKE_PREFIX = /usr
 DEB_CONFIG_INSTALL_DIR = $(DEB_CMAKE_PREFIX)/share/kde4/config
 DEB_HTML_INSTALL_DIR = $(DEB_CMAKE_PREFIX)/share/doc/kde/HTML
-BASE_CMAKE_DEFS = -DWITH_QT5=ON -DKDE_INSTALL_BINDIR=$(DEB_CMAKE_PREFIX)/bin -Wno-dev
+BASE_CMAKE_DEFS = -DWITH_QT5=ON -DKDE_INSTALL_BINDIR=$(DEB_CMAKE_PREFIX)/bin -Wno-dev -DWITH_FFMPEG=ON
 
 %:
 	dh $@ --parallel --builddirectory=kid3-build
@@ -16,8 +16,6 @@
 		-DCMAKE_INSTALL_PREFIX=$(DEB_CMAKE_PREFIX) \
 		$(BASE_CMAKE_DEFS) \
 		-DLIB_INSTALL_DIR=$(DEB_CMAKE_PREFIX)/lib/kid3 \
-		-DCMAKE_C_COMPILER:FILEPATH="$(CC)" \
-		-DCMAKE_CXX_COMPILER:FILEPATH="$(CXX)" \
 		-DCMAKE_C_FLAGS="$(CFLAGS)" \
 		-DCMAKE_CXX_FLAGS="$(CXXFLAGS)"