[Pkg-kde-extras] Bug#922574: digiKam FTBFS with OpenCV 4

[Agustin Martin]

On Tue, Dec 10, 2019 at 01:55:50PM -0500, John Scott wrote:
> Control: forwarded -1 https://bugs.kde.org/show_bug.cgi?id=401306
> 
> This appears to have been fixed upstream. There are a couple patches there.

Hi all,

I have been playing with this problem and with changes in upstream bug
report and I was finally able to make digikam 5.9.0 build in sid. 

I have prepared a personal build with those changes (it is minimally
tested, so is initially intended for my personal use), and I am attaching a
debdiff with the changes as well as individual patches under debian/patches
for clarity.

That personal build is apparently working for my preliminary tests and
is intended to fix both
  
  #922574 digikam: FTBFS against opencv 4
  #918478 digikam: ImageEditor window is blank when opened a second time

as well as a problem with libkf5calendar.

Steve, feel free to use these changes at your convenience. If needed I can
prepare a NMU, but I would appreciate some additional testing first.

Summary of the patches under debian/patches follow:

 * 0010_libopencv.h_update-for-opencv4-remove-obsolete-stuff.diff:
   Update libopencv.h.cmake.in for opencv4 and remove obsolete stuff.
   Based on upstream changes in https://bugs.kde.org/show_bug.cgi?id=401306.

 * 0011_facesengine_fix-openCV4-compilation.diff:
   Update for opencv4 (and some opencv3).
   Original patch by Gilles Caulier modified to deal with buster opencv
   (seems that it also needs to use cv::IMREAD_GRAYSCALE). Version should
   be fine tuned, but seems to work with both buster and sid.

 * 0020_calsettings.cpp_Fix-for-recent-libkf5calendarcore.diff:
   Fix calsettings.cpp for libkf5calendarcore-dev_4%3a19.08.3
   KCalCore namespace has been renamed to KCalendarCore. Just set a
   namespace alias to work around this.

   This will not work for buster libkf5calendarcore-dev_4%3a18.08.3.
   Comment that alias if a backport is needed.

 * 0030_fix-blank-imageeditor.patch:
   Fix ImageEditor window is blank when opened a second time (#918478)
   Changes borrowed from http://bugs.debian.org/918478

Please find attached above patches and the debdiff for my personal build.

Hope this helps

-- 
Agustin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010_libopencv.h_update-for-opencv4-remove-obsolete-stuff.diff
Type: text/x-diff
Size: 1757 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-extras/attachments/20200117/950ff912/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011_facesengine_fix-openCV4-compilation.diff
Type: text/x-diff
Size: 1528 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-extras/attachments/20200117/950ff912/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0020_calsettings.cpp_Fix-for-recent-libkf5calendarcore.diff
Type: text/x-diff
Size: 758 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-extras/attachments/20200117/950ff912/attachment-0002.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0030_fix-blank-imageeditor.patch
Type: text/x-diff
Size: 2155 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-extras/attachments/20200117/950ff912/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: digikam_5.9.0-1_TO_5.9.0-1.0~amd1.diff
Type: text/x-diff
Size: 9712 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-extras/attachments/20200117/950ff912/attachment-0003.diff>