[Pkg-kde-extras] Bug#906882: libqt5gstreamer-dev: pkg-config fails unless libgstreamer-plugins-base1.0-dev is also installed

[Simon McVittie]

Control: severity -1 serious
Control: tags -1 + patch

On Tue, 21 Aug 2018 at 20:19:31 +0100, Toby Speight wrote:
> * aptitude install libqt5gstreamer-dev
> * pkg-config --cflags Qt5GStreamer-1.0
> 
>   /--------
>   | Package gstreamer-audio-1.0 was not found in the pkg-config search path.
...
>   | Package 'gstreamer-audio-1.0', required by 'Qt5GStreamer-1.0', not found
>   \--------
> 
> This package should have a dependency (at least Recommends) on
> libgstreamer-plugins-base1.0-dev, otherwise its pkg-config file is
> unusable.

I noticed this bug report while looking at unrelated release-critical
bug #997252 in the same package.

This class of bug is generally considered to be release-critical,
although arguably it might not be RC for libqt5gstreamer-dev if the
functionality of libqt5gstreamer-dev is normally located via CMake and
only rarely via pkg-config (maintainers: please downgrade if the .pc
files are considered to be unimportant in this particular package).

The .pc files also depend on libraries from libglib2.0-dev and
libgstreamer1.0-dev; in practice those get pulled in by installing
libgstreamer-plugins-base1.0-dev, but for completeness it's probably best
to add them as Depends explicitly. I would suggest the attached patch.

Qt5GStreamerQuick-1.0.pc also depends on a library from
qtdeclarative5-dev, which the other pkg-config modules do not. Any
level of dependency relationship between Depends and Suggests could be
argued to be correct here, depending on whether use of
Qt5GStreamerQuick-1.0.pc is common, rare or somewhere in between.

In the attached patch I've gone for Recommends, but the package's
maintainers would know better what's appropriate here.

> Alternatively, perhaps the pc files need to be shuffled between packages?

I think they are in the correct package, it just needs more dependencies
as you said.

    smcv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-missing-dependencies-on-GLib-GStreamer-dev-packa.patch
Type: text/x-diff
Size: 1337 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-extras/attachments/20220722/64672b95/attachment.patch>