[Pkg-kde-extras] Bug#1077495: amarok FTCBFS: pkgconf-based mariadb detection is broken

[Helmut Grohne]

Source: amarok
Version: 3.0.1-3.1
Tags: patch upstream
User: debian-cross at lists.debian.org
Usertags: ftcbfs

amarok fails to cross build from source, because it fails to detect
mariadb. It actually has two methods for detecting mariadb. It first
tries mariadb_config and then also tries pkgconf. The former method is
unfixably broken for cross compilation, because mariadb_config is an ELF
executable and it either cannot be run or reports results for the wrong
architecture. The native build successfully uses mariadb_config. For
cross compilation, the only reasonable way is using pkgconf. While the
package is correctly detected, the fallback mechanism is subtly broken
as it expects a cmake variable MYSQL_LIBRARIES to be set, but that
variable (unlike MYSQL_INCLUDE_DIR and MySQL_VERSION_STRING) is only set
by the mariadb_config and considered required producing the failure. I'm
attaching a patch that also initialized MYSQL_LIBRARIES from pkgconf
when available. After applying it, cross building amarok works. I
suggest forwarding the patch upstream as it will also help other
distributions such as Yocto or PtxDist but have not done so myself.

Helmut
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cross.patch
Type: text/x-diff
Size: 367 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-extras/attachments/20240729/b90b23a3/attachment.patch>