[Pkg-kde-extras] Bug#1072473: rkward: FTBFS on riscv64 due to timeout on test

[Bo YU]

Source: rkward
Version: 0.7.5-3
Severity: important
Tags: ftbfs, patch
User: debian-riscv at lists.debian.org
Usertags: riscv64
X-Debbugs-Cc: debian-riscv at lists.debian.org

Dear maintainer,

rkward has a ftbfs issue on riscv64 due to timeout on core_test:

```
...
=== Received signal at function time: 44586ms, total time: 44587ms, dumping stack ===
=== End of stack trace ===
44584: QFATAL : RKWardCoreTest::initTestCase() Received signal 11
         Function time: 44586ms Total time: 44587ms
FAIL!  : RKWardCoreTest::initTestCase() Received a fatal error.
   Loc: [Unknown file(0)]
Totals: 0 passed, 1 failed, 0 skipped, 0 blacklisted, 44591ms
********* Finished testing of RKWardCoreTest *********


0% tests passed, 1 tests failed out of 1

Total Test time (real) =  45.83 sec

The following tests FAILED:
	  1 - rkward-core_test (Subprocess aborted)
Errors while running CTest
make[2]: *** [Makefile:74: test] Error 8
...
```

The full buildd log is here: 
https://buildd.debian.org/status/fetch.php?pkg=rkward&arch=riscv64&ver=0.7.5-3&stamp=1716877944&raw=0

I proposed a patch to increase the timeout for the test case failed and
it works but it looks like a bit ugly. could you have any idea that how
to improve it?

I have reported this to upstream also. please let me know if any issues.
https://mail.kde.org/pipermail/rkward-devel/2024-May/006037.html


-- 
Regards,
--
  Bo YU

-------------- next part --------------
diff -Nru rkward-0.7.5/debian/changelog rkward-0.7.5/debian/changelog
--- rkward-0.7.5/debian/changelog	2024-05-28 13:28:08.000000000 +0800
+++ rkward-0.7.5/debian/changelog	2024-06-02 18:08:46.000000000 +0800
@@ -1,3 +1,11 @@
+rkward (0.7.5-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Increase the timeouts for core_test on riscv64 to fix ftbfs.
+    (Closes: #-1)
+
+ -- Bo YU <tsu.yubo at gmail.com>  Sun, 02 Jun 2024 18:08:46 +0800
+
 rkward (0.7.5-3) unstable; urgency=medium
 
   * Team upload.
diff -Nru rkward-0.7.5/debian/patches/increase_timeout_on_riscv64.patch rkward-0.7.5/debian/patches/increase_timeout_on_riscv64.patch
--- rkward-0.7.5/debian/patches/increase_timeout_on_riscv64.patch	1970-01-01 08:00:00.000000000 +0800
+++ rkward-0.7.5/debian/patches/increase_timeout_on_riscv64.patch	2024-06-02 18:08:09.000000000 +0800
@@ -0,0 +1,43 @@
+Description: increase timeouts for core_test on riscv64 
+ Already discussed this issue with upstream. See URL below
+Author: Bo YU <tsu.yubo at gmail.com>
+Origing: https://mail.kde.org/pipermail/rkward-devel/2024-May/006037.html
+Last-Update: 2024-06-02
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/rkward/autotests/core_test.cpp
++++ b/rkward/autotests/core_test.cpp
+@@ -27,6 +27,15 @@
+ #include "../core/renvironmentobject.h"
+ #include "../misc/rkcommonfunctions.h"
+ 
++/* have to increase timeout on riscv64 */
++
++#define IS_RV64 0
++
++#if defined(__riscv) && (__riscv_xlen == 64)
++  #undef IS_RV64
++  #define IS_RV64 1
++#endif
++
+ QElapsedTimer _test_timer;
+ 
+ void testLog(const char* fmt, va_list args) {
+@@ -65,7 +74,7 @@
+ 		bool *_done = &done;
+ 		connect(command->notifier(), &RCommandNotifier::commandFinished, this, [_done, callback](RCommand *command) { *_done = true; callback(command); });
+ 		RInterface::issueCommand(command, chain);
+-		while (!done && (t.elapsed() < timeoutms)) {
++		while (!done && (t.elapsed() < (IS_RV64 ? timeoutms * 5 : timeoutms))) {
+ 			qApp->processEvents();
+ 		}
+ 		if (!done) {
+@@ -99,7 +108,7 @@
+ 		QElapsedTimer t;
+ 		t.start();
+ 		while (!(RInterface::instance()->backendIsDead() || RInterface::instance()->backendIsIdle())) {
+-			if (t.elapsed() > 40000) break;
++			if (t.elapsed() > (IS_RV64 ? 63000 : 40000)) break;
+ 			qApp->sendPostedEvents();
+ 		}
+ 		if (RInterface::instance()->backendIsIdle()) {
diff -Nru rkward-0.7.5/debian/patches/series rkward-0.7.5/debian/patches/series
--- rkward-0.7.5/debian/patches/series	2024-05-28 13:02:29.000000000 +0800
+++ rkward-0.7.5/debian/patches/series	2024-06-01 12:24:55.000000000 +0800
@@ -1,2 +1,3 @@
 upstream_Fix-not-a-string-literal-compile-error.patch
 upstream_Fix-compilation.patch
+increase_timeout_on_riscv64.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-extras/attachments/20240602/dd7a0ca5/attachment.sig>