[Pkg-kde-talk] Re: [Pkg-kde-commits] rev 705 - in branches/kde-3.4.0: . packages/kdegraphics/debian

[Adeodato Simó]

* Christopher Martin [Sat, 05 Mar 2005 23:48:17 +0100]:

> +shlibs_ver=4:3.4.0
> -$(foreach p,$(PACKAGES_WITH_LIBS),$(eval DEB_DH_MAKESHLIBS_ARGS_$(p) := -V))
> -
> -# Overrides for DEB_DH_MAKESHLIBS_ARGS_foo can go here
> -# shlibs_ver=4:3.3.99
> +$(foreach p,$(PACKAGES_WITH_LIBS),$(eval DEB_DH_MAKESHLIBS_ARGS_$(p) := -V'$(p) (>= $(shlibs_ver))'))

  I'm not sure I see the benefits of this. -V already put >= 4:3.4.0
  there (as per DH_COMPAT=4), and now one has to update shlibs_ver by
  hand upon each new upstream release.

  I understand that having the $(foreach) use $(shlibs_ver) can be good,
  so that only changing shlibs_ver is enough should it be necessary. If
  that was your intention, what about having this (4:3.4.0-1 -> 4:3.4.0)?
  
    shlibs_ver=$(shell echo $(DEB_VERSION) | sed -e s/-[^-]*$//)

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
    Listening to: Elton John - All that I'm allowed
 
I don't want to achieve immortality through my work. I want to achieve
immortality throguh not dying.
                -- Woody Allen