[Pkg-kde-talk] Re: [Pkg-kde-commits] rev 705 - in branches/kde-3.4.0: . packages/kdegraphics/debian

[Christopher Martin]

--nextPart2308076.5O12Jmn6ha
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On March 5, 2005 22:18, Adeodato Sim=F3 wrote:
> * Christopher Martin [Sat, 05 Mar 2005 23:48:17 +0100]:
> > +shlibs_ver=3D4:3.4.0
> > -$(foreach p,$(PACKAGES_WITH_LIBS),$(eval DEB_DH_MAKESHLIBS_ARGS_$(p)
> > :=3D -V)) -
> > -# Overrides for DEB_DH_MAKESHLIBS_ARGS_foo can go here
> > -# shlibs_ver=3D4:3.3.99
> > +$(foreach p,$(PACKAGES_WITH_LIBS),$(eval DEB_DH_MAKESHLIBS_ARGS_$(p)
> > :=3D -V'$(p) (>=3D $(shlibs_ver))'))
>
>   I'm not sure I see the benefits of this. -V already put >=3D 4:3.4.0
>   there (as per DH_COMPAT=3D4), and now one has to update shlibs_ver by
>   hand upon each new upstream release.
>
>   I understand that having the $(foreach) use $(shlibs_ver) can be good,
>   so that only changing shlibs_ver is enough should it be necessary. If
>   that was your intention, what about having this (4:3.4.0-1 -> 4:3.4.0)?
>
>     shlibs_ver=3D$(shell echo $(DEB_VERSION) | sed -e s/-[^-]*$//)

This was to allow shlibs bumps on branch pulls, without always forcing a=20
bump, since not all uploads may need one.

Cheers,
Christopher

--nextPart2308076.5O12Jmn6ha
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Signed by Christopher Martin <chrsmrtn@freeshell.org>

iD8DBQBCKny2U+gWW+vtsysRAr0bAKCKw/cw3El+2ODkvSLaNlqrKmQVzwCeLRt0
phx+sClE7JK2rHyWTJ/gDwo=
=bdbf
-----END PGP SIGNATURE-----

--nextPart2308076.5O12Jmn6ha--