latte-dock review

[Lisandro Damián Nicanor Pérez Meyer]

El martes, 6 de marzo de 2018 10:38:06 -03 Lisandro Damián Nicanor Pérez Meyer 
escribió:
[snip]
> I have not checked copyright, will do with the next upload.

And this is what I'm currently doing now. The file is just fine, all 
copyrights seems to be OK.

You can improve this file for the next upload. According to https://
www.debian.org/doc/packaging-manuals/copyright-format/1.0/ you can group files 
and copyright holders with the same license.

For example the stanzas:

Files: *
Copyright: 2014, David Edmundson <davidedmudnson at kde.org>
                  2016, 2017, Smith AR <audoban at openmailbox.org>
                  Michail Vourlakos <mvourlakos at gmail.com>
License: GPL-2+

Files: app/*
Copyright: 2016, 2017, Smith AR <audoban at openmailbox.org>
License: GPL-2+

Files: app/Messages.sh
  app/visibilitymanager_p.h
Copyright: 2014, David Edmundson <davidedmudnson at kde.org>
License: GPL-2+

Can become:

Files: *
Copyright: 2014 David Edmundson <davidedmudnson at kde.org>
    2016-2017 Smith AR <audoban at openmailbox.org>
    Michail Vourlakos <mvourlakos at gmail.com>
    Smith AR <audoban at openmailbox.org>
License: GPL-2+

There is an extra gotcha here: I removed some commas in the years definitions. 
Check the copyright format url above and see why I did this.

That + the fact that the package was uploaded unreleased makes me ask you to 
fix that and upload the package already released to unstable. I'll happily 
upload it after that.

= Repo

Do you have a repo for latte-dock packaging that I can clone to add it to 
salsa? Or should I just create a new one?

-- 
"So long, and thanks for all the fish!"
  The Hitchhickers guide to the Galaxy

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20180309/87f6b9fb/attachment.sig>