Packaging review for the Elisa music player

[Aurélien COUDERC]

Hi,

this is quick feedback now that the latest stable version of elisa reached
unstable, including all the changes you suggested below.

One test runtime dependency that was non-trivial to find and was making tests
fail in sbuild and not on my machine was the libkf5filemetadata3 / 
libkf5filemetadata-bin pair, required for some tests manipulating audio files. 

I also added the basic --help autopkgtest that hefee suggested.


Builds are failing for mipsel [1] and mips64el [2] on buildds but I don’t think
I can be of much help with these.

[1] https://buildd.debian.org/status/fetch.php?pkg=elisa-player&arch=mipsel&ver=1.1%2Breally0.4.2-1&stamp=1567950781&raw=0
[2] https://buildd.debian.org/status/fetch.php?pkg=elisa-player&arch=mips64el&ver=1.1%2Breally0.4.2-1&stamp=1567961632&raw=0


Enjoy !

--
Aurélien


Le 10/02/2019 à 12:05, Pino Toscano a écrit :
> In data domenica 10 febbraio 2019 11:13:37 CET, Aurélien COUDERC ha scritto:
>>> - the .so symlink of the elisalib library is shipped in the binary
>>> package; as the library is private, just drop the .so file -- see for
>>> example the dh_auto_install override in krita
>>
>> It’s fixed upstream here:
>> https://phabricator.kde.org/differential/changeset/?ref=352877
>>
>> So I’ll leave it like that for now and wait for the upstream change to
>> reach us.
> 
> Or backport that patch, since it's easy enough.
> 
>>> - the syntax used in the dh_auto_test override (i.e. "cmd1; cmd2; cmd3")
>>> basically ignores the failures of the commands, currently the fact that
>>> xvfb-run is missing; one possible idea is to use a simple directory for
>>> XDG_RUNTIME_DIRS like debian/tests.home, cleaning it before and after
>>> the real dh_auto_test run -- see the dh_auto_test override in tellico,
>>> for example
>>
>> OK fixed.
>> I had done that so the build would reach 100% even with some failing
>> tests but it was supposed to be temporary.
> 
> There are better ways to do so:
> - tell make to ignore failing commands, by prefixing "-" to a command
> - ignore the failure of a specific command, eg with "|| true"
> 
>> Also I’ve added a couple of runtime dependencies to ensure it works when
>> installed on top of a default Gnome install.
> 
> Please do not add libkf5mediaplayer5 as explicit dependency, as its
> version will be added by shlibdeps.
> 
>> I’ll upload now as time is running out. :)
> 
> It is already too late: packages not in testing in two days will not
> be allowed for buster.  Considering elisa must pass through NEW, then
> this is definitely not going to happen.
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20190908/27c34547/attachment.sig>