Packaging review for the Elisa music player

[Sandro Knauß]

Hey,

> this is quick feedback now that the latest stable version of elisa reached
> unstable, including all the changes you suggested below.

great! I don't know if you aware of debian-kde at lists.debian.org, there is also 
a small discussion going on about elisa 0.4.2
https://lists.debian.org/msgid-search/2327651.N8u3bXfFNb@merkaba

> One test runtime dependency that was non-trivial to find and was making
> tests fail in sbuild and not on my machine was the libkf5filemetadata3 /
> libkf5filemetadata-bin pair, required for some tests manipulating audio
> files.

I know, it often hard to reproduce failures. That is the main reason I use 
sbuild locally, so it is easier to reproduce. I suggest mk-sbuild ( from the 
package ubuntu-dev-tools) and the wiki page: https://wiki.debian.org/sbuild.

> I also added the basic --help autopkgtest that hefee suggested.

nice.

> Builds are failing for mipsel [1] and mips64el [2] on buildds but I don’t
> think I can be of much help with these.

You should try out if you can reproduce the failure on a porter box. If not 
that request a rebuild other wise get in contact with the arch maintainers
Than you should get in contact with the arch-dependend lists
mipsel at buildd.debian.org and mips64el at buildd.debian.org
to sort out if that is a upstream issue often they know already a patch, than 
than should move upstream. There are also the non release critical archs and 
you should also have a fast check if there is something obvious to fix and 
maybe also get in contact with the $arch at buildd.debian.org lists...

An other way to fix that is to disable tests for specific archs, like I did for 
owncloud-client, as the tests just doesn't make sense on FreeBSD atm:
https://sources.debian.org/src/owncloud-client/2.5.1.10973+dfsg-1/debian/
patches/0003-skip_tests_freebsd.patch/

hefee
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20190913/b4bf618e/attachment.sig>