Review kgeotag

Hefee hefee at debian.org
Mon Mar 28 11:30:02 BST 2022


Hey,

you requested per IRC, that kgeotag is ready for upload.
Thanks for your work, the most seems fine. I start a review and there are 
still some small issues and hints:

d/copyright:
* missing the Overall Copyright infomation aka:
 Files: * entry GPL-3.0-or-later
 (to match all files without any copyright information like po files)

* GPL-3.0-or-later and GPL-3+ are the same License - use one name
* the License text for GPL-3+ is the text for GPL-2+ ;)
* Files: po/ca/*
          po/ca at valencia/*
          po/uk/*
   Copyright: 2020-2021, This_file_is_part_of_KDE
   License: LGPL-2.1+3+KDEeV

* I would recommend to split listing files and the License descriptions. That 
makes it much easier to read the licenses for files, without scroll the long 
lincense texts. 
  see https://salsa.debian.org/qt-kde-team/kde/kontact/-/blob/master/debian/
copyright
* wrap text to 80 chars

d/control:
* see my merge request as suggestion:
https://salsa.debian.org/qt-kde-team/extras/kgeotag/-/merge_requests/1
* replace tabs with spaces
* the short and long description should be refreshed.
   - you do not need to mention that it is Free/Libre Open Source
   I would use the summery and description in the appdata.xml:

Photo geotagging program

Images can be associated with geographic coordinates (geotagging) by different 
means: On the one hand, a matching with GPX encoded geodata can be done, on 
the other hand, the coordinates can be set manually, either via drag and drop 
onto a map, via bookmarks or by manually supplying them. The coordinates can 
be stored in the images' Exif header and/or in XMP sidecar files.

regards

hefee
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20220328/ed647ed5/attachment.sig>


More information about the pkg-kde-talk mailing list