Need someone to check my code

[Hefee]

Hey,

Many thanks for all your work so far!

Now the last step after the new release was accepted:

* create a signed tag: `pkgkde-vcs tag -s`

I'll give you developers rights for the repo, so you can directly upload your 
tag. 

I don't gave you now developer rights, as it is your first repo in Debian I 
think it is good to still use merge requests to make sure we are on the same 
page regarding how to maintain a repo in our team.

You can also now enable CI/CD for the repo. You know how do do that?

Btw. now you can see on the tracker page, that you still need to wait 5 days 
till it migrate to testing:
https://tracker.debian.org/pkg/kup-backup

hopefully nothing popping up that are additionally preventing the migration.

Regards,

hefee

PS: I would be happy to see merge requests in other repos ;)
PPS: you may want to look at our tools/scripts that help us a lot for the 
recurring tasks. I havn't mentioned them earlier, as they add another layer of 
abstraction to the process, that are harder to understand:
https://salsa.debian.org/qt-kde-team/pkg-kde-dev-scripts
https://salsa.debian.org/qt-kde-team/pkg-kde-dev-scripts/-/tree/master/
function_collection?ref_type=heads

--

On Dienstag, 1. April 2025 03:56 Bob Wong wrote:
> > that is great - how you contacted them?
> 
> Use email address in copyright info and directly send an email to them
> privately.
> 
> > I commented already. Mostly cosmetic changes. IMO it will be ready for an
> > upload after this round.
> > 
> > the freeze date are different than you expect. There is a migration period
> > of unstable -> testing with 5 days. That means the package must be
> > without any serious bug for 5 days in unstable to migrate to testing.
> > That means I need to upload at least 5-6 days before the freeze to get it
> > to trixie.
> 
> Thanks for clarifying that.
> 
> > I simple read the heading to sorted the bugreports to different lines. If
> > you think, it makes sense on different lines than change this, of if I
> > forget one bug to close please fix.
> 
> Looks like they're all correct. I'll update changelog in my own branch
> and fix other things you mentioned. And then I'll mark it as
> ready-to-review.
> 
> Regards,
> 
> Benxi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20250403/e2d10638/attachment.sig>